Handle any link text for VPR configuration file anchors #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaauie
commented
Mar 10, 2023
| .gsub("<<path,path>>", "{logstash-ref}/configuration-file-structure.html#path[path]") | ||
| .gsub("<<uri,uri>>", "{logstash-ref}/configuration-file-structure.html#uri[uri]") | ||
| .gsub("<<bytes,bytes>>", "{logstash-ref}/configuration-file-structure.html#bytes[bytes]") | ||
| content = fix_configuration_file_structure_links(content) |
There was a problem hiding this comment.
Would you find this more readable if you had an "intercept_anchors" helper that took the content, a list of anchors to intercept, and the page to re-route them to like:
content = intercept_anchors(content, %w(string array number boolean hash password path uri bytes), "{logstash-ref}/configuration-file-structure.html")
There was a problem hiding this comment.
Not sure we want to make deviating from the standard so easy. If we add a new input type, we should vet it and possibly update the lists of inputs.
logstash-plugins/logstash-filter-elasticsearch#166 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces hard-coded link text replacements for configuration file anchors with a function that accepts and propagates any link text for the supported anchors